Ryan Powell comments

Results 877 comments of


                                            Ryan Powell

NimBLELocalValueAttribute::setValue() doesn't accept a char*??

I noticed this as well today, will investigate. Workaround for now is `setValue((uint8_t*)val, strlen(val));`

Guidance for thread safety

All value functions are thread safe, getters make a copy inside a critical section and values are changed inside critical sections.

NimBLELocalValueAttribute::setValue(const uint8_t* data, size_t size) doesn't report an error if the size is larger than 512 bytes

Yes, there should be some sort of notice so that the dev knows where to look.

refactor(RemoteServ): Reduce nesting

Looks good and I agree with the consolidation thought. Not sure if creating/inheriting from a class for this purpose is the way to go because the client class would also...

refactor(RemoteServ): Reduce nesting

Probably not, unless it's an empty service, which would be weird. Wouldn't be the worst idea to add it anyway though.

refactor(RemoteServ): Reduce nesting

I'm not concerned with the naming, as long as it's somewhat consistent throughout the library and obvious/readable for casual observers as to what they represent, in this case the original...

refactor(RemoteServ): Reduce nesting

>Some of the BLE jargon just adds so much bloat when written in full like characteristic, descriptor, etc.; which then causes the need to break function calls up with one...

Add explicit keyword to constructors

I think `m_deviceInfoSvc = server->createService(NimBLEUUID(deviceInfoSvcUuid));` is probably fine here as it's an internally managed class so application code isn't affected, still quite readable as well.

Add explicit keyword to constructors

It might be, depending on the application. I would suggest adding the HID changes to this PR so we can test the builds at least. Maybe add some more build...