Heberto Mayorquin

Handle ms_before and ms_after difference between waveforms and template extensions

3

They might be different, we can either raise an error like here or change to a warning and priviledge the ones of the waveform as we are doing right now....

SortingAnalyzer.get_extension() should fail when the extension does not exist

10

This will be more consistent with the principle that thing should fail early. I think that returning None the way that we are doing currently: https://github.com/SpikeInterface/spikeinterface/blob/024c24afaec2d0a0476017c77a75f7c8a1dcb4b3/src/spikeinterface/core/sortinganalyzer.py#L1084-L1101 Can introduce hard to...

Remove unused extractor attribute `extractor_name`

1

Ok, this is within the context of the discussion in https://github.com/SpikeInterface/spikeinterface/pull/2784 This is an unused attribute as far as my search skills in the repo point out. There is a...

Sorting analyzer does not propagate sparsity to template extension

1

```python from spikeinterface.core import create_sorting_analyzer from spikeinterface.core import generate_ground_truth_recording job_kwargs = dict( n_jobs=1, progress_bar=False, verbose=False, chunk_duration=1.0, ) recording, sorting = generate_ground_truth_recording(num_channels=384, durations=[10], seed=0) analyzer = create_sorting_analyzer(sorting, recording, sparse=True, format="memory", **job_kwargs)...

Improve `save_to_folder` docstring

1

The old one is confusing and has references to `extractor_name` which can be confusing as some classess do have that attribute (at least for now).

Protect hdbscan import in `TdCClustering`

1

This is causing some problems on import tests. Would that work like this?

Should the landing page of the documentation point to stable or latest?

11

This was raised by @JoeZiminski on https://github.com/SpikeInterface/spikeinterface/issues/2763 and I think is worth discussing. > A general question, is the 'latest' docs the ones built from main? I always thought that...

Should `get_traces` with `return_scaled=True` when the base dtype is float.

2

From the discussion inhttps://github.com/SpikeInterface/spikeinterface/pull/2864 We have the following lines: https://github.com/h-mayorquin/spikeinterface/blob/bc0cbd9f74f30cfed9376f984091cd57f3634169/src/spikeinterface/core/baserecording.py#L369-L373 But if the original dtype is float64 this will downcast. Maybe we should change the code a little bit.

Avoid returning std when asking for only mean/average with templates extension

3

As in the title, should close #2867

Templates extension computes std even when I ask for average/mean only.

1

The `compute_templates` extension has `return_std` harcoded to `True` : https://github.com/h-mayorquin/spikeinterface/blob/0942fda7ce60c644a397c8d86c091eba6f07706d/src/spikeinterface/core/analyzer_extension_core.py#L333-L343