gzhao9
gzhao9
@jesperronn Please feel free to let me know if there is anything I need to change. I look forward to your suggestions.
> Thanks for the cleanup, @gzhao9. I think there is already a `MockSecurityContextHolderStrategy` available in `spring-security-core`. Can you please enhance that instead? > > I think it would be reasonable...
I first focus on each file code modification. I will rebase commits when there is no need to modify the code or format.
> Thanks for the updates, @gzhao9! I think there are two other items from the review that haven't been addressed yet. Are you able to do those as well? I...
> Thanks for taking out the time. I donot see value in this refactor. This adds another layer which is used in a single testClass. Thank you for your feedback....
> > Thanks for taking out the time. I donot see value in this refactor. This adds another layer which is used in a single testClass. > > Thank you...
> Hi, @gzhao9. Will you please squash your commits so that there are only 4 in the PR? I've squashed it and only have 4 commits, which correspond to the...
I encountered a problem while trying to rebase and update to the latest main. I mistakenly closed the PR and then discovered that I do not have permission to reopen...
> Thank you for your effort @gzhao9 to simplify these tests! To accelerate the review process, will you please instead open a PR to [the main repository](https://github.com/spring-projects/spring-security/compare) and I'll take...
@cryptoe Thank you very much for your reply in Issue. I have merged both PRs, #15187 and #15217 into this current PR.