spring-security icon indicating copy to clipboard operation
spring-security copied to clipboard

Refactoring Test Code to Reduce Duplication of Mock Object Creation for Issue#14768

Open gzhao9 opened this issue 1 year ago • 4 comments

Hi there,

This PR is to address issue #14768, which involves reducing repeated mock object creation in tests.

Although my issue submission mentioned 4 separate draft PRs, I combined them into this PR, since they all address the same problem.

If you prefer these changes to be split into separate PRs, please let me know, and I will gladly close this PR and submit individual ones.

gzhao9 avatar Jun 15 '24 01:06 gzhao9

@gzhao9 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Jun 15 '24 01:06 pivotal-cla

@gzhao9 Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Jun 15 '24 01:06 pivotal-cla

Hi, @gzhao9. Will you please squash your commits so that there are only 4 in the PR?

jzheaux avatar Jun 24 '24 21:06 jzheaux

Hi, @gzhao9. Will you please squash your commits so that there are only 4 in the PR?

I've squashed it and only have 4 commits, which correspond to the 4 examples I mentioned in issue #14768.

gzhao9 avatar Jun 25 '24 03:06 gzhao9

I encountered a problem while trying to rebase and update to the latest main. I mistakenly closed the PR and then discovered that I do not have permission to reopen it, receiving the message this branch was force pushed or recreated. What should I do in this situation? Should I create a new PR, or can an administrator reopen it? @jzheaux

gzhao9 avatar Jul 11 '24 05:07 gzhao9