Ho Cheung

Results 137 comments of Ho Cheung

> Hi, > > How can I disable these colored icons on the toolbars? I like the regular grey icon colors better. I'm using Thorium_AVX2_106.0.5199.0 at the moment. > >...

> using https://github.com/Alex313031/Thorium-Win/releases/tag/M109.0.5362.0 the issue doesn't seem fixed: ![image](https://user-images.githubusercontent.com/6506529/196379883-1622cc44-8afe-4ef7-af61-a5337f5c127e.png) ![image](https://user-images.githubusercontent.com/6506529/196380013-0e650aa2-e4fd-4de0-8fe6-8d32aceccaba.png) @ThaUnknown Hi, can you send me the URL of your video? I'll test it here.

> @gz83 ah yes. url. @ThaUnknown sorry i didn't see the url you sent

> > > @gz83 ah yes. url. > > > > > > @ThaUnknown sorry i didn't see the url you sent > > yes, because it was a sarcastic...

> @pierro78 @MarkGhanz @mzinner @midzer @gz83 I added that patch as well as an omnibox patch!! [08267e6](https://github.com/Alex313031/Thorium/commit/08267e6810b4b0c3b17b060378531b0036da4feb) and [9a28926](https://github.com/Alex313031/Thorium/commit/9a289261833dca49db59542684f541e02330e9c7) @Alex313031 wow that's nice

> Was trying to compile Thorium on Ubuntu 20.04 and found that 'chromium/src/content/browser/gpu/shader_cache_factory.cc' was missing when running ./build.sh. After creating it, around 22000 of the 55000 targets were built successfully...

> @Alex313031 That seems to have fixed those issues. Get these new errors now: > > ``` > ../../chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc:1951:6: error: use of undeclared identifier 'IDS_SETTINGS_SAFETY_CHECK_UNUSED_SITE_PERMISSIONS_PRIMARY_LABEL' > IDS_SETTINGS_SAFETY_CHECK_UNUSED_SITE_PERMISSIONS_PRIMARY_LABEL}, > ^ >...

> @Alex313031 That seems to have introduced another error: > > ``` > ../../third_party/blink/common/features.cc:1562:32: error: unused variable 'kPretokenizeInlineSheets' [-Werror,-Wunused-const-variable] > const base::FeatureParam kPretokenizeInlineSheets = { > ^ > 1 error...

> @gz83 These changes seem to already be present in features.cc after [687d839](https://github.com/Alex313031/Thorium/commit/687d83972bbb3777c486222dee2e54fcbfc2645e). @RudraSwat Please try to delete the newly added code in lines 1560-1564 in this file and compile...

> @gz83 That seems to have resulted in even more linking errors: > > ``` > ld.lld: error: undefined symbol: content::URLLoaderClientCheckedRemote::URLLoaderClientCheckedRemote(mojo::PendingRemote) > >>> referenced by service_worker_installed_script_loader.cc > >>> lto.tmp:(content::ServiceWorkerInstalledScriptLoader::ServiceWorkerInstalledScriptLoader(unsigned int,...