thorium icon indicating copy to clipboard operation
thorium copied to clipboard

How to disable colored toolbar icons?

Open danielstreba opened this issue 2 years ago • 3 comments

Hi,

How can I disable these colored icons on the toolbars? I like the regular grey icon colors better. I'm using Thorium_AVX2_106.0.5199.0 at the moment.

Thanks.

image

danielstreba avatar Aug 13 '22 09:08 danielstreba

Hi,

How can I disable these colored icons on the toolbars? I like the regular grey icon colors better. I'm using Thorium_AVX2_106.0.5199.0 at the moment.

Thanks.

image

@Alex313031 @danielstreba These icons have been changed at the code level, and how to deal with this issue needs to be decided by Alex

gz83 avatar Aug 13 '22 10:08 gz83

@danielstreba @gz83 I know they can be changed, as you can see in the TOOLBAR_TINT property when making a chrome theme, which changes the clours. I would like to add a flag which changes the colours of the .icon files, instead of hard coding them in the .icon files themselves. I understand that not everyone will want the new colours, I will work to make it an option rather than hard coded.

Alex313031 avatar Aug 13 '22 10:08 Alex313031

@danielstreba Still having trouble making this something not hard coded. Although I have reverted the reload button icon and cookies icon to blue, because using the greenish color of the chrome labs icon makes it too hard to see in light mode.

Alex313031 avatar Aug 22 '22 06:08 Alex313031

@danielstreba @gz83 Checking back in. Gz83, this is something still on the roadmap. Now that we have worked out pretty much all bugs and issues except all the win avx2 issues, I will be focusing more of my attention on developing a chrome://flags flag to toggle top bar icons. Its just a matter of finding where in source code this applies. It is not WebUI, but rather native chrome views. I feel that maybe thorium_ui_debug_shell could help with this. There is somewhere in code that sets the TINT variable, and this could be used to set the colours in the .icon files, without hard coding them in RGB like I showed you before.

Alex313031 avatar Oct 18 '22 04:10 Alex313031

image bump, this just doesn't work well with themes AT ALL

im-tem avatar Apr 15 '23 07:04 im-tem

Hi @Alex313031 been using Thorium for a while and having the same issue here, doesn't look good on any colored theme. Hope this can be fixed! So close to be perfect :)

l3ony2k avatar Oct 17 '23 19:10 l3ony2k

The color of the icon changed because we hardcoded the color in the code, and we may change the icon subsequently

@Alex313031

gz83 avatar Oct 18 '23 03:10 gz83

@Alex313031 maybe potentially revert them back to the default white while you still work on making it not hard coded?

joaocastilho avatar Oct 19 '23 06:10 joaocastilho

Was looking to replace ungoogled chromium with Thorium but this is a blocker for me, also the contrast ratio is poor which affects accessibility

image

neo773 avatar Nov 04 '23 17:11 neo773

@joaocastilho @danielstreba @im-tem @neo773 Added in all releases now that M121 is released today. Closing issue now.

Alex313031 avatar Feb 20 '24 08:02 Alex313031