Glenn Willen

Results 29 comments of Glenn Willen

I've been noticing the same thing, e.g. testing just now from California, I got USA three times, Tunisia once, Czech Republic once, and Canada once. I would call that 4/6...

This looks correct, and I see what it's fixing and why. It should probably be merged.

Am I correct in understanding that the function of this is just to make things not break on python3 systems? Do you think you got all of them? And am...

This looks totally sensible and should probably get merged.

EDIT: Nevermind, disregard my comment. It seems like actually the behavior was exactly what was expected (SSL session fell over but irssi itself was ok.)

Filed #52 about trait default method implementations. Also, it seems to not see code that's under `#[cfg(test)]`, which @connorff mentioned maybe taking a look at.

Ugh, the circular dependency lint is really mad about this. @stevenroose, do you think this approach (extending the use of ValidationState into CheckProof) is worth trying to rescue, or I...

@stevenroose This is kind of ancient, do you have an opinion on whether to close it or try to rescue it? I will default to closing.

(to avoid duplication, it might actually make sense to change the original interface instead of adding another one, if you like this approach -- but adding an interface is certainly...