elements icon indicating copy to clipboard operation
elements copied to clipboard

Improve logging of failures during block signature validation

Open gwillen opened this issue 4 years ago • 3 comments

Pass in a ValidationState object to CheckProof and friends, so that we can provide helpful error messages when validation fails.

@stevenroose This came out of the time I spent figuring out the problem we were seeing with Elements and Liquid regtest syncing.

gwillen avatar Jun 30 '20 09:06 gwillen

Ugh, the circular dependency lint is really mad about this. @stevenroose, do you think this approach (extending the use of ValidationState into CheckProof) is worth trying to rescue, or I should just add some simple log messages and call it a day?

gwillen avatar Jul 01 '20 20:07 gwillen

It seems to me that the main differentiator it adds is "signature too large" vs "invalid signature" which could be valid information. IIRC when either of this happens, we ban the peer, right? So I'm not super worried about excessive logging if you'd just add another line indicating those 2 different scenarios..

stevenroose avatar Jul 09 '20 12:07 stevenroose

@stevenroose This is kind of ancient, do you have an opinion on whether to close it or try to rescue it? I will default to closing.

gwillen avatar Mar 30 '21 00:03 gwillen