gwenn

Results 517 comments of gwenn
trafficstars

Would it possible to generate only one other bindgen file instead of two ? Because the difference between the two is only: ```diff --- sqlite3/bindgen_bundled_version-ext.rs 2020-02-15 11:50:57.736323438 +0000 +++ sqlite3/bindgen_bundled_version-ext-embed.rs...

I don't know why we cannot use `loadable_extension` with the `bundled` version ? ```rust if cfg!(feature = "loadable_extension") { panic!("Building a loadable extension bundled is not supported"); } ```

I don't know how to test the `dummy-extension` module ? Generate another module with `load_extension` and use a relative path while calling [sqlite3_load_extension](https://docs.rs/rusqlite/0.21.0/rusqlite/struct.Connection.html#method.load_extension) ?

There is [test-cdylib](https://crates.io/crates/test-cdylib) but we need incompatible features to test the generated extension ! ```toml [dependencies.rusqlite] path = ".." default-features = false features = ["loadable_extension", "functions", "vtab"] version = "0.21.0"...

Sorry, last commits (on Jun 13) are wrong: at least changes on bindgen files...

> I've updated this PR to work with the current version of rusqlite here: https://github.com/phiresky/rusqlite/tree/gwenntest > Seems to work, just needs recreation of the bindgen files for the non-bundled versions....

> See a note in #910 regarding this PR not adhering to the conditions of the license under which code contributed in #532 was provided: [#910 (comment)](https://github.com/rusqlite/rusqlite/pull/910#issuecomment-791485983) > > The...

Which version of `rusqlite` is used ? Current version of [get_raw](https://docs.rs/rusqlite/0.24.1/rusqlite/struct.Row.html#method.get_raw) panics (no `Result`). And [get_raw_checked](https://docs.rs/rusqlite/0.24.1/rusqlite/struct.Row.html#method.get_raw_checked) doesn't panic but returns a `Result

Maybe : ```rust impl Row { pub fn map(&self, idx: I, f: F) -> Result where F: Fn(ValueRef