gwenn

Results 528 comments of gwenn

Ok, we should be able to check parameters now: https://github.com/gwenn/lemon-rs/blob/master/src/lexer/sql/test.rs I am not sure mixed parameters are count properly though: https://sqlite.org/lang_expr.html#parameters https://github.com/gwenn/lemon-rs/blob/master/src/parser/ast/mod.rs#L75-L85

Just for reference: https://github.com/google/cpp-from-the-sky-down/tree/master/rust (full SQLite parser ?)

Maybe we should try https://docs.rs/rust_decimal/1.18.0/rust_decimal/struct.Decimal.html#method.serialize and https://docs.rs/rust_decimal/1.18.0/rust_decimal/struct.Decimal.html#method.deserialize

See https://github.com/mamcx/rusqlite/pull/1

> I need to do something else? See https://github.com/rusqlite/rusqlite/runs/4564693209?check_suite_focus=true

> Hi, do I need to do anything else to see this merged, or just wait :) > P.D: This my first pull request ever so I unsure what are...

> `From` is not implemented for Decimal for a reason. Bypassing that by casting to a string is incorrect. You mean from SQLite3 REAL I guess. And it is: https://github.com/rusqlite/rusqlite/pull/1061/files#diff-dca35f2dce05c5640f8c7f1acc59fdd46c6f34c881f4464029ac8922851770faR20

Could you provide a minimal example to reproduce this issue ?

I guess you need a mutable reference to `Statement` to reprepared / step, no ? So you should not be able to keep a reference to column names and step....

Are you ok to introduce [trybuild](https://crates.io/crates/trybuild) tests that don't compile ? ```rust let t = trybuild::TestCases::new(); t.compile_fail("tests/column_names.rs"); ``` ```rust fn main() -> Result src/column.rs:243:17 | 242 | let column_names =...