gwenn

Results 548 comments of gwenn

Yep, something like https://github.com/rusqlite/rusqlite/pull/506

You should be able to use [FromSqlError::Other](https://docs.rs/rusqlite/latest/rusqlite/types/enum.FromSqlError.html#variant.Other), no ? And can just mark your PR as a draft...

What about: ```rust pub trait SubType : ToSql { fn sub_type(&self) -> Option { None } } ``` ?

@thomcc You mean we should allow `RETURNING` clause even if result is ignored ? We should be able to do it with [sqlite3-parser](https://github.com/gwenn/lemon-rs/blob/master/src/parser/ast/mod.rs#L252).

May I suggest that `hooks` is kept untouched and a new feature `pre_update_hook = ["libsqlite3-sys/pre_update_hook", "hooks"]` is used instead (`libsqlite3-sys/pre_update_hook` should be used to activate the `SQLITE_ENABLE_PREUPDATE_HOOK` compile-time option).

> However the "problem" with that is that it might be confusing that `hooks` does not encompass all hooks. By default, SQLite does not encompass all hooks so it seems...

`rusqlite` is designed such as `Connection` are not `Sync`. Based on Rust guarantees, the `sqlite3` handle can be set to `multi-thread` mode (instead of `serialized` mode). It seems wise because...

While introducing `FallibleStreamingIterator` : https://github.com/rusqlite/rusqlite/pull/478/files I was delighted except for one point: https://github.com/sfackler/fallible-streaming-iterator/issues/1