Gurukiran

Results 9 comments of Gurukiran

@agriyakhetarpal I've updated the tests to align with the new citations.py implementation. At the moment, only a few tests are passing I'm still working on the rest. I want your...

> It looks like a stable release for `bibtexparser` v2 is not yet available, and the resolver picks up pre-release versions only if we specify them. Could you please pin...

@agriyakhetarpal The test_citations test seems to be failing because read_citations() isn't populating _all_citations, so keys like "Sulzer2021" are missing during assertions. I suspect this might be due to the CITATIONS.bib...

Actually the current error I'm seeing is an AssertionError, not an ImportError. It's happening because _all_citations is empty, so the test fails when it checks for "Sulzer2021".

Thanks for pointing that out! the ImportError stems from my use of BibDatabase, which was part of bibtexparser v1 but has been removed in v2. I mistakenly mixed v1-style imports...

Hi @agriyakhetarpal , I've pushed the updated code, and most methods and their tests are passing as expected However, there's an issue with the register method, causing tests like test_citations...

I switched back to bibtexparser==2.0.0b8, I have pushed the updated code. I run the tests using pytest. I also verify specific tests by running: pytest -k test_citations -v Please let...

@agriyakhetarpal I've pushed the latest updated code addressing most of the test failures and feedback Refactored the register method and _add_citation to support bibtexparser v2+ Made citation handling optional using...

@agriyakhetarpal , @kratman , I've pushed the latest code please review when you get a chance