Gürgün Dayıoğlu comments

Results 202 comments of


                                            Gürgün Dayıoğlu

feat: support local reference in schema, support definitions keyword

I agree that this plugin needs a rewrite/refactor

The lookupToken function doesn't seem to receive the cookie options.

> I too am seeing this issue. I'm using @fastify/cookie with @fastify/jwt, and the cookies property is never initialized. I believe this is fallout from a change in @fastify/cookie [#248](https://github.com/fastify/fastify-cookie/pull/248)...

isConnectionSecure() is duplicate code from @fastify/cookie/plugin.js

Closed by https://github.com/fastify/session/pull/238

enhance checkOptions to reject invalid signer objects

CI failed, can you take a look?

enhance checkOptions to reject invalid signer objects

Yeah I remember now

perf: make ipv4 regex faster

Can you comment this out and say it's not valid? We now parse it correctly to 10.10.0.10 but it's no longer compatible... https://github.com/fastify/fast-uri/blob/b9f7726c4cd3d93c01cec7a32837eaa10b7deec8/test/compatibility.test.js#L13

perf: make ipv4 regex faster

Thanks @kurtextrem

feat: move /organisations to /organizations

It was because the website uses American English everywhere else

Implement simple B-Tree for faster string comparisons

Maybe switch, but Sets let us centralize supported methods and they are usually as fast as it gets when used with only one type > Why don't we use hashing...