Gürgün Dayıoğlu
Gürgün Dayıoğlu
> const {a} = foo; > console.log(foo.a); > // PASS Writing the obvious, but the rule should check if foo.a was assigned to a new value and not warn if...
> Your opinions? Afaik you wanted to replace busboy in undici with this version. Do you see any drawbacks? Should be doable, I'll try to take a look at this
Anything that violates the spec should emit an error as fast as possible in my opinion Clearly the RFC says that a part MUST have a name value However, I...
> There is actually no way to handle a part without name gracefully @Uzlopak could you tell why? If emitting an error for a malformed part and continuing is not...
> So we should throw an error if we have a part without a name, right? Yeah, the RFC says it must have it.
I see, I guess it's because busboy is event based But in any case, throwing (or at least emitting an error and stopping) would still be more correct in implementations...
I’ll take a look at this, thanks!
probably ts issue
Oh, that’s true, it might need a benchmark
I don't really get how, but a `proxyrequire` in one tests breaks another: `jobs: 1` doesn't fix it either https://github.com/fastify/releasify/blob/0de5b403c74d71c47127b9958e7856a2da0570d5/test/command-config.test.js#L33-L44 These lines cause this test to fail: https://github.com/fastify/releasify/blob/0de5b403c74d71c47127b9958e7856a2da0570d5/test/args.test.js#L67-L97 Error: ```sh...