Rohit Gupta

Results 28 comments of Rohit Gupta

Hi, @carlosms thanks for the PR :octocat: :heart: These options are definitely needed, here I'm little skeptical about the name of the options. They actually mean `MinLower`, `MinUpper`; if possible,...

@jesseduffield if I understand correctly these options ensure the minimum lower bound of the graph (therefore MinLower) & minimum upper bound of the graph(therefore MinUpper), as [L64](https://github.com/guptarohit/asciigraph/blob/22e3e1b9e3cd5ab4f79619cd65987f426d2d3dc4/options.go#L64) > It will...

hi @jesseduffield, I actually meant MinLower and MinUpper (edited my comment now, please check)

@jesseduffield I'm afraid it won't be like that as per this PR, please check the test case [ #16](https://github.com/guptarohit/asciigraph/blob/22e3e1b9e3cd5ab4f79619cd65987f426d2d3dc4/asciigraph_test.go#L211) or check the O/P by following example: ```go data := []float64{-2,...

Hi @NathanBaulch, good catch! I would personally like `offset` to be space before the y-axis label, maybe we could have another parameter so that we could handle both. I checked...

@CSenshi good idea :+1: Yes, we gotta refactor `Plot` function, and I was also thinking to add support for multi-graph. Please feel free to create PR :) p.s. _sorry for...

@cxd1995 Thanks for pointing out this case :+1: Currently, the only way I see to distinguish the coin with the same coin-code is by explicitly providing its coinmarketcap-id to fetch...

No, it doesn't accept coinmarketcap-id as input currently, will need make changes for that.

sure @MAWUT0R :+1:

Hi @taosue, can please share some [mcve](https://stackoverflow.com/help/minimal-reproducible-example) if possible.