Yiqun Zhang comments

Results 12 comments of


                                            Yiqun Zhang

ORC-998: Sharing compression output buffer among treeWriter: Refactoring within OutStream for portability

LGTM, Nit: TestOutStream.java line 82 has an extra space

Add C++ API for Columnar Encryption

I looked at the commit history of the Java api. It seems like a lot of work. Maybe we should follow the steps of the Java implementation and divide it...

Java impl does not fully adhere to the usage contract of `ColumnVector.noNulls` and `ColumnVector.isNull`

cc @williamhyun @dongjoon-hyun @wgtmac

Add support for integer number to varchar coercer in unpartitioned table

Hi @Praveen2112, could you please review this PR when you get a chance? Thanks!

Add support for integer number to varchar coercer in unpartitioned table

@Praveen2112, I have addressed all the comments. Can you help review again? Thank you very much!

Add support for integer number to varchar coercer in unpartitioned table

CI hit https://github.com/trinodb/trino/issues/18392

Attempt to evaluate the value of `TryFunction` in `ExpressionInterpreter`

CI hit https://github.com/trinodb/trino/issues/16277

Translate SimpleCase expression to connector expression

I've sent the signed CLA. 😄

Translate SimpleCase expression to connector expression

Would greatly appreciate if one of you could review this pr. Thank you for your time and efforts.

Translate SimpleCase expression to connector expression

Thank you for your review. It's already late at night where I am, so I will need to address these issues tomorrow.