trino icon indicating copy to clipboard operation
trino copied to clipboard

Add support for integer number to varchar coercer in unpartitioned table

Open guiyanakuang opened this issue 1 year ago • 8 comments

Description

Add support for integer number to varchar coercer in unpartitioned table.

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text:

# Section
* Add support for integer number to varchar coercer in unpartitioned table

guiyanakuang avatar Jul 14 '23 15:07 guiyanakuang

Hi @Praveen2112, could you please review this PR when you get a chance? Thanks!

guiyanakuang avatar Jul 21 '23 07:07 guiyanakuang

@Praveen2112, I have addressed all the comments. Can you help review again? Thank you very much!

guiyanakuang avatar Jul 27 '23 08:07 guiyanakuang

CI hit https://github.com/trinodb/trino/issues/18392

guiyanakuang avatar Jul 27 '23 13:07 guiyanakuang

Sorry for the delay. Will take a look at this PR soon

Praveen2112 avatar Aug 28 '23 08:08 Praveen2112

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jan 12 '24 17:01 github-actions[bot]

:wave: @guiyanakuang and @Praveen2112 - this PR has become inactive. We hope you are still interested in working on it. Please let us know, and we can try to get reviewers to help with that.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.

mosabua avatar Jan 12 '24 17:01 mosabua

@guiyanakuang Will you mind rebasing the PR so as to resolve the conflicts

Praveen2112 avatar Feb 02 '24 14:02 Praveen2112

Lets' restrict truncation for coercion today. Sorry for the initial confusion

Praveen2112 avatar Feb 16 '24 11:02 Praveen2112

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Mar 08 '24 17:03 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Apr 01 '24 17:04 github-actions[bot]