Guillaume Valadon

Results 152 comments of Guillaume Valadon

@hyunel can you fix the linting errors? The lines that you added in scapy/layers/tls/session.py are too long.

Thanks for the PR. Could you fix the flake8 issues at https://github.com/secdev/scapy/actions/runs/13262979518/job/37023594039?pr=4663 ?

Thanks for this PR! This looks good to me. Could you add corresponding unit tests into https://github.com/secdev/scapy/edit/master/test/scapy/layers/inet6.uts ? This will ensure that your code works as expected, and catch future...

The interface ID is purely internal to a PCAPng file. It is only meant to avoid duplicating data. Unless you can give us a use case, I agree with @gpotter2:...

Thanks for the fix! I guess that a test should also be added, using a pattern similar to https://github.com/secdev/scapy/blob/master/test/scapy/layers/x509.uts#L53 I managed to decrease the size of the certificate to 480...

You can test Scapy with `UTScapy` as described in https://scapy.readthedocs.io/en/latest/development.html#testing-with-utscapy. It is simpler to launch the tests using `tox` (see https://scapy.readthedocs.io/en/latest/development.html#using-tox-to-test-scapy) as it will take care of many things for...

Thanks for the PR! We just discussed this internally with the Scapy maintainers team. This PR brings a lot of changes and it makes it difficult to review and make...

I have a similar behavior with Tailscale: ``` >>> get_if_hwaddr("utun7") '00:00:00:00:00:00' ``` Here are some helpful outputs: ``` ifconfig utun7 utun7: flags=8051 mtu 1280 options=6460 inet6 fe80::6f7a:67ff:feb8:a001%utun7 prefixlen 64 scopeid...

I agree that scapy/contrib is a good solution. VSCs can for example be loaded with `load_contrib("bluetooth_vsc_realtek")`, and will avoid conflicting VSCs to be loaded at the same time. How many...

This look good to me. I agree that conflicting VSCs must be handled by the end users if they need a to mix and match them.