Guillaume Valadon comments

Results 152 comments of


                                            Guillaume Valadon

Proposal: net range

Looks like a good idea for the last byte. Other bytes such as ("192.168.0.28", "192.168.16.64") might be 1 but trick to implement or understand.

Support In-situ Operation Administration and Maintenance (IOAM)

@jingfeihu it looks like some tests are failing. I converted your PR to a draft. Feel free to modify it when it is ready.

Fixed docstring of return value of the srloop and srploop functions

Thanks for this PR!

Fix missing TLS packets and recognizing TLS encrypted data

Thanks for your interest in Scapy. Could you share an example that triggers the issue? For example by adding a pcap file to a github comment.

Fixed fragment data size in IPv6 defragmentation

Could you share an example that triggers the issue that your are aiming to fix? That will allow us to understand your PR.

Fixed fragment data size in IPv6 defragmentation

Thanks for your explanation. Could you add a unit test based on your example at https://github.com/secdev/scapy/blob/master/test/scapy/layers/inet6.uts#L1817 ?

Interface names must start with `tun` or `tap` on BSD and Darwin

That’s indeed a bug. Do you feel like submitting a PR?Sent from my iPhoneOn 28 Jun 2023, at 07:38, Matt Bolognani ***@***.***> wrote: Brief description The tun interfaces on my...

Netflow packets built by Scapy fail to decode when they contain timestamps

Thanks for your interest in the project. Could you share a single Scapy packet that reproduces this behavior, along with the expected correct packet?

[Draft Pull Request] Proof of concept Mac utun support

Thanks for this PR. I will give it a try. In the meantine, could you fix the PEP-08 issues https://github.com/secdev/scapy/actions/runs/5920584081/job/16053137679?pr=4100#step:5:1 ?

Attempting to craft or modify a STUN packet using the STUN contrib results in AttributeError: tlvlist

Thanks for the report. I believe that no one really used this code to build a packet, does this patch works for your use case? ``` diff --git a/scapy/contrib/stun.py b/scapy/contrib/stun.py...