Guillaume Valadon

Results 152 comments of Guillaume Valadon

The others maintainers might have a different opinion.

One test case is small (~100 bytes), while the two others one are big (1k+ bytes). I could try to reduce the big ones if you think that it is...

@gpotter2 I managed to strip down the test cases to 12, 100 and 140 bytes. If that's OK for you, I will add the corresponding unit tests.

@oskar456 sorry for the delay. I slightly modified this PR and it should now work as expected. Do you have time to test it?

Thanks for your report.Can your share a complete example to reproduce the issue and ideally a target ?Sent from my iPhoneOn 3 May 2024, at 12:46, BlobbyBob ***@***.***> wrote: Brief...

FTR, this PR does not make x509-parser compile on macOS. The current linker flags does not work on macOS.

FTR, flake8 complains about an import error

I welcome comments, yet this needs to be tested against several big pcap files before being merged.

@evverx That's a good catch! Thanks a lot for fuzzing it. This is indeed the piece of the code that I was not able to test.

This is ready to be reviewed.