Gulshan Singh

Results 164 comments of Gulshan Singh

@remexre it would help if you could describe what the issue with the stubgen types is. Do you think we'll need to make the stubs from scratch or just tweak...

Sure, I have a number of fixes and improvements locally. If you want me to update this project with them, you can grant me contributor privileges.

@ssl19 thanks for that snippet! Can you explain what the purpose of `my/burly-savehist-integration` is? Shouldn't saving and restoring `burly-opened-bookmark-name` work fine without it?

I was having the same issue and `redsocks` worked for me. I found out the reason was because `redsocks` provided more complete instructions in their README about iptables rules: ```...

> Maybe tcpsocks's own connections were also redirected by iptables? Yes, that's exactly what happened. > One solution was to run tcpsocks as a separate user Makes sense, but most...

Maybe `cargo source` or `cargo get-source`? I prefer the former but don't feel too strongly about the name.

This doesn't address all of your points, but I'd suggest we move logic regarding iteration over the heap into the heap class itself, like this: https://github.com/gsingh93/pwndbg/blob/0268e3196468c0e6d72452a527ab3bf5e6fd1293/pwndbg/commands/heap.py#L125-L126 Any bounds checking in...

@disconnect3d This is ready for review now. The PR is large, but the main things to look at are `lib/config.py` and `gdblib/config.py`. If you could also test this locally, that...

> long namespaces, aka: pwndbg.gdblib.config.syntax_highlight is long to read/write ;p Yea, you actually brought this up before I even started all this refactoring work, and we couldn't figure out anything...

> but for long namespaces perhaps we should move pwndbg.gdblib to just gdblib? If you want to give this a shot, I'm supportive of it. But there were so many...