grhkm21
grhkm21
> We should also discuss how to efficiently check the order of the curve candidates. @grhkm21 proposed to probabilistically check curves' orders instead of computing them and comparing naively. This...
Also it seems how you/I implement the loop is buggy, because on the second iteration of the `while True` when you loop over the powerset, you will also loop over...
Please don't do whatever you did that caused the force push.
@JosePisco has notified me that he isn't free the next few weeks, so I applied the following patch file and created this patch file ~~(waiting for him to apply or...
Hey @vincentmacri , I added a few changes to `EllipticCurve_with_order` (not `with_prime_order`) as well, mainly refactoring + reversing the order of `D` to start searching from smaller absolute value `D`....
This PR fixes #38342 as well after reversing the order of searching $D$.
> > This PR fixes #38342 as well after reversing the order of searching D . > > Add "Fixes #38342" to the PR description to make sure the issue...
I don't see problems if they fit in the PR naturally, as it was required to create the example of failing `has_order`. If you want to, feel free to isolate...
I think I can get someone to add you to the group. Thanks for the review.
> Thanks for the fix! Usually, a PR should address only one issue. I suggest that we fix the incorrect exponentiation of graded modular forms here and implement q-expansion conversion...