grembo

Results 24 comments of grembo

@jefferai I would like to pick this up, how to approach this best - should I simply start a new pull request?

> Looks like a duplicate? Isn't that already covered by PR #38 ? There's overlap: 1. Both address the error I mention above 2. #39 also incorporates the missing ssh_transfer_method...

@mcgaw @austinhyde I commented on #36, so in general it works, but having a minimum ansible version check would be useful - opened #37 to address this.

@mcgaw It seems like this was due to a bug introduced in ansible in https://github.com/ansible/ansible/commit/935528e22e5283ee3f63a8772830d3d01f55ed8c#diff-38cec806ea1a1ee7c3a286c7865334ecfba7ccc49e21d4e8fb8ec1b17938fda6, which affected 2.11.0, 2.11.1, and 2.11.2. It was corrected it https://github.com/ansible/ansible/commit/a2239d88191794f0f8f1d21c7a63ecd85ec4349e, which made it to...

> I mentioned it on the PR too, but I'm seeing the same quoting bug on 2.12.1. Yes, like mentioned on the PR, this is a bug in sshjail that...

> When renaming "reconnection_retries" back to "retries" in sshjail.py, I can execute my playbooks successfully, so I think the parser change works just fine now. > > Still requesting change,...

> FWIW I'm having to apply this patch for Ansible 2.12. It looks like the fix was only applied on the 2.11 branch? There is some confusion - the patch...

Thanks for the patch, that helped me. I also needed #34 applied for it to work properly though.

@v-zhuravlev Any chance to get this in? Anything I should change/explain? Thanks for providing these dashboards!