ansible-sshjail
ansible-sshjail copied to clipboard
Unbreak sshjail: Add changes for ansible 2.12
Fixes this error:
ansible.errors.AnsibleError: Requested entry (plugin_type: connection plugin: sshjail setting: pkcs11_provider ) was not defined in configuration.
Looks like a duplicate? Isn't that already covered by PR https://github.com/austinhyde/ansible-sshjail/pull/38 ?
Looks like a duplicate? Isn't that already covered by PR #38 ?
There's overlap:
- Both address the error I mention above
- #39 also incorporates the missing ssh_transfer_method from https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/ssh.py#L296-L297
- #39 adds pkcs11_provider 1:1 from current https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/ssh.py#L347-L357 - these are just cosmetic differences, but having it identical makes sense for future diffs/development
- #38 adds an important fix to _copy_file, which is not addressed by #39 (it's a different issue)
So ideally, they are combined, e.g., by updating #38 with the points 2. and 3. mentioned above and then closing this one as a duplicate.
Thank you very much @grembo for the explanation and pointing out the differences of both pull requests.