Fabian Greimel
Fabian Greimel
What about allowing `MetaGraphs.graph isa SimpleWeightedGraph` and then defaulting to the SimpleWeightedGraphs behavior? (I guess this would be very confusing) So what about having an alternative type like `MetaWeightedGraph` or...
Thank you for your responses! My question was not how to use LightGraphs, but *why* it works the way it does. Why doesn't `adjacency_matrix(::SimpleWeightedGraph)` produce a matrix of {0,1} but...
For a consistent behavior in the ecosystem, these things would have to change 1. `adjacency_matrix(::SimpleWeightedGraph)` returns a matrix of 0 and 1 2. `weights(::MetaGraph)` are 0 for unconnected nodes
I think you are misunderstanding. `adjacency_matrix(::SimpleWeightedGraph)` DOES NOT return a matrix of Ints. Moreover, `adjacency_matrix(::SimpleWeightedGraph, Bool)` gives an error. see my code snipped from the OP ```julia using LightGraphs, SimpleWeightedGraphs...
Very good! I am happy to prepare a PR. What about point two of > For a consistent behavior in the ecosystem, these things would have to change > >...
> > Do you agree that weights of a MetaGraph should be zero for unconnected nodes? > > I'm not convinced yet. Ok, so let me give another try. ##...
I guess we agree then that the current behavior is a bug. Here's the other part of the code snippet from the OP. ``` using LightGraphs, MetaGraphs, GraphDataFrameBridge, DataFrames begin...
I could live with that. But it would keep the inconsistencies between `MetaGraphs` and `SimpleWeightedGraphs`, which is not very nice. Either of the two changes I am proposing is breaking,...
I'd appreciate if you could reopen this. I don't think the issue is solved. (It's just that I was busy with other things.) If you create the same graph, once...
Just in case other people are playing with this. I adapted the GHA workflow (along with some necessary adjustments) in a fork of this repository https://github.com/greimel/18S191-reduced/blob/main/.github/workflows/ExportNotebooks.yml https://greimel.github.io/18S191-reduced/notebooks_week12_how_to_collaborate_on_software/ Unfortunately, it doesn't...