gregorydemay

Results 7 comments of gregorydemay

chore(IDX): rename test_utils bazel targets to their unique crate names

Cross-chain changes LGTM!

fix(icos): Several testing and performance improvements to SetupOS

Removing cross-chain team since the label was due to the PR being out-of-date with master.

feat: Add support for `eth_estimateGas` method

Thanks a lot @francesco-gaglione for this PR! We are a bit swamped at the moment but should have time next week to review your PR. Sorry for the delay 🙏...

Hash trate for Hex structs in evm-rpc-types

HI @AlexEmets ! That's something we could add. Note that there are some caveats using HashMap in a canister: 1. Re-allocation could encounter the instruction limit. 2. It could be...

Add a note on sig existence guarantees

> When we say "Note that, in some cases" we could maybe mention/link to bounded-wait calls? In general, my understanding was that we would make the documentation more explicit about...

Add a note on sig existence guarantees

Thanks @oggy-dfin for the new formulation! My problem with it is that it's very vague: "in some cases", "more likely to happen", "may also happen in other request failure cases"....

Refactor to remove `cketh-minter` dependency

@rvanasa @THLO I started to look into a bit more details as to what this would entail and came up with the following rough plan (please feel free to comment/challenge...