portal icon indicating copy to clipboard operation
portal copied to clipboard

Add a note on sig existence guarantees

Open oggy-dfin opened this issue 4 months ago • 4 comments

Previously we didn't specify anything about what happens when a call to a signing point fails for whatever reason. Clarify to say that we don't guarantee that no signature was computed, so that applications don't rely on this signature being unique.

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a pull request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

oggy-dfin avatar Aug 13 '25 12:08 oggy-dfin

When we say "Note that, in some cases" we could maybe mention/link to bounded-wait calls? In general, my understanding was that we would make the documentation more explicit about using bounded-wait calls and threshold signatures. Do you plan to add anything specific in the documentation of bounded-wait calls?

I also find the addition, while worthwhile, not specific enough. I think we should have a table comparing threshold signatures with bounded-wait calls vs unbounded-wait calls.

gregorydemay avatar Aug 22 '25 11:08 gregorydemay

Sorry, dropped the ball on this one. Would the following formulation be satisfactory?

Note that, in some cases, a signature may be computed when requested, but not returned to the requesting canister. Thus, canisters should not rely on the signature not existing even if the signing request fails. In particular, the signature existing despite the signing request failing is more likely to happen if the request is made using a bounded-wait call to the management canister which times out. However, it may also happen in other request failure cases too (regardless of the whether the request was done using a bounded- or unbounded-wait call).

@andreacerulli @gregorydemay

oggy-dfin avatar Oct 08 '25 12:10 oggy-dfin

Thanks @oggy-dfin for the new formulation! My problem with it is that it's very vague: "in some cases", "more likely to happen", "may also happen in other request failure cases". But actually, we know exactly under which circumstances this type of behaviour may occur. As I mentioned in my previous message, I think a table comparing the guarantees of threshold signing under bounbed/unbounded wait calls would bring more clarity.

gregorydemay avatar Oct 16 '25 04:10 gregorydemay