Greg Navis comments

Results 39 comments of


                                            Greg Navis

Add new checker for incorrectly configured associations

Nice job, @fatkodima! I merged some other PRs and started reviewing this one. I'll try to finish the review over the next few days. In the meantime, could you fix...

incorrect_length_validation: Consider `inclusion` validations as an alternative

Also, could we add a test case with an enum?

missing_presence_validation: ignore counter cache columns

Thanks for the nudge, @fatkodima! I won't merge them all today, as I'd like to see some changes made, but I definitely need to pay attention to the outstanding PRs....

missing_presence_validation: ignore counter cache columns

@fatkodima, you are not lazy at all! I totally understand supporting 4.2 is a total pain in the ass. I marked this and a few other PRs for 2.0.

`missing_presence_validation` incorrectly marks `numericaility` with `allow_nil: false` as missing a presence validator

@vanharen, thank you for your comment. Discussion is always much appreciated! I don't think treating `allow_nil: false` (which is the default as you mentioned) is a good idea. Technically, it...

Suggestion: Allow (or require) foreign keys to use BigInt even if the primary uses Integer

Thanks for reporting the problem, @hlascelles! I really like your idea! I think you can proceed with the PR.

Detector for tables without models

Hi @robinaugh! Thank you for using the tool and for your effort to file the issue. I love the idea, so feel free to proceed with a PR. Right now,...

log should handle different bases symbolically

:+1: I'd love to see this implemented. I think I can help but I need your guidance. Where should I start?

Suggestion: Require timestamp columns to have timezone

Thank you for opening the issue and providing so much context. The PRs you linked were very interesting. Let me reiterate your proposal: we'd add a new checker that would...