Greg Navis

Results 39 comments of Greg Navis

... unless, we're open to adding some special syntax for those cases. Not sure if it'd be useful for other column types, though.

No problem, @rxhanson! Appreciate you taking time to look into that. I'm on Mac Mini and shutdown and boot up my system every day. It seems the item persists, though....

@Numie, I think what's wrong here is that the error message should be different: it should tell you to add `optional: false` to the association. I'm working on that enhancement....

@fatkodima, you're right. I was confused by the fact that belongs_to seem not to be required by default in active_record_doctor test suite. For example, when I took your PR and...

Thanks for the link. Sadly, it seems the default is not set within the active record gem. I prefer not to add an explicit dependency on the `rails`. however, given...

@mhenrixon, thank you for opening the issue. As you said, we shouldn't be testing Rails implementation details, and that's not the goal of this validator. In your example, it's still...

> > In your example, it's still possible that the column would end up being set to `nil,` for example via: > > It isn't possible because the column is...

This doesn't look right. See the discussion on the corresponding issue.

I think this fits with the overall goal of `rack-attack`. An extension would be a good place for preventing specific kinds of attacks. This is different, though: we're adding a...

> Out of curiosity, what's the reasoning behind 80 chars line length limit? It's a bit of legacy + convenience when working with split windows. I usually have a soft...