Greg

Results 216 comments of Greg

Oh, I forgot: https://github.com/bazelbuild/bazel/commit/7f51c8b374f6f6c5b2185e50baf8bb9aa9131fd3 could help with rules that really have no configuration needs. That's limited to solving these problems with more transitions, and would need a Starlark hook to...

Thanks for quickly tackling #16911 @fmeum.

> @gregestren Thank you for your detailed response. I totally respect the complexity regarding these issues (and I have seen most of them), especially for the general case and I...

I think the ctexplain followups are 1. https://github.com/bazelbuild/bazel/pull/17109 (yours) 2. https://github.com/bazelbuild/bazel/pull/13210 (mine, closed due to review inactivity) 3. https://github.com/gregestren/bazel/commits/ctexplain_more_analyses 4. and funny enough, https://github.com/gregestren/bazel/commit/fe42dcfaffb2d98a3b43bd6a9d196eec8631913a which also covered some of what...

Note that https://bazel-review.googlesource.com/c/bazel/+/208644 enables this flag by default, which I believe we can re-ping when we've closed this and https://github.com/bazelbuild/bazel/issues/17032.

@joeleba what's the configurability tie here? i.e. is the toolchain issue about the generic toolchain API or C++-specific?

> Considering the options are the same, even though the configurations are different Can you clarify this comment? You mean `-rpath /usr/lib/swift` is the same, repeated twice? Not that the...

I'm not sure how the Swift logic sets and gets the linkopts info (the linkopts are set in a `swift_toolchain`?). But going by https://github.com/bazelbuild/bazel/issues/19103#issue-1824828258 - and making this about pure...

> It's hard for me to think of an answer that isn't specific to C++ logic. i.e. "C++ linkopt logic intelligently deduplicates".

I think I see the problem. As https://github.com/bazelbuild/rules_go/issues/3851#issuecomment-1933861883 mentions, `--experimental_platform_in_output_dir` defaults the path to the platform's base label name (like `:foo`). Which can easily clash. But if you set `--experimental_use_platforms_in_output_dir_legacy_heuristic`...