Greg
Greg
> @gregestren would know best when exactly `cfg = "host"` became/becomes equivalent to `cfg = "exec"`. That definitely wasn't the case in Bazel 4. I believe Bazel 6.0. `--distinct_exec_configuration`is definitely...
Early evidence is this breaks Bazel's own tests: `//src/test/shell/bazel:bazel_bootstrap_distfile_test` fails because of a `grpc` repo dependency with `cfg="host"`.
> 👋 What is the status of this PR? > > Context: I have a job that takes average 5min to run. The build was inadvertently discarding the analysis cache....
> I'm not sure where this fits on @mattem 's current workload. I'll see if I can clarify the linked comment a bit more clearly, since it leaves room for...
I support the `finished` approach as the sole solution to this problem. i.e. an iteration of the code I shared with a new type vs. `CONFLICTING_CONFIGURATIONS`. I think this addresses...
Just back from vacation last week. Looking forward to reviewing the updates...
Since we're getting close to submission, I want to signal boost @mattem 's [old comment](https://github.com/bazelbuild/bazel/pull/16805/files#r1027147051) about flag naming. The current name is `--fail_on_analysis_cache_discard`. @mattem noted an alternative suggestion is `--disallow_analysis_cache_discards`....
I'm fine with `allow_analysis_cache_discard` (the core flag is defined with as a positive action, without negations). And the boolean parsing logic automatically supports the `no` variant. I'm generally fine with...
Hey @mattem - I saw you had some new commits recently. Were you ready for the next (last?) round?
Everything looks good to me, aside from the branch conflict (I imagine it's not a big one) and the failing CI. [One](https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/0187c425-d8e0-4a89-8efb-0fbd4143b47b/src/test/java/com/google/devtools/build/lib/analysis/AnalysisTests/shard_5_of_12/test_attempts/attempt_1.log) of the CI failures is: ``` Executing tests...