Greg

Results 100 comments of Greg

I've run into this theme before. I think it can happen for different reasons. Do you know if `--keep_going` affects this? I committed https://github.com/bazelbuild/bazel/commit/c56497707f283f3aa1ab34abbcb88470fb5f3207 a while ago to handle another...

@EdSchouten do you have a recommended reviewer for this PR? Or at least team (https://bazel.build/maintaining/maintainers-guide.html#team-labels)? I can route as make sense to me, but if we can route to anyone...

I believe `Core` is more focused on the core execution engine, i.e. Skyframe. I assigned `team-Rules-Server` for lack of a better label. @lberki should actually be a good contact but...

So basically, I'm trying to get this proper attention in accordance with https://bazel.build/maintaining/maintainers-guide.html#lifecycle-of-a-pull-request. Ping me specifically if you worry about responsiveness, but as a heads up I'd expect this one...

I was pinged. So I'll give this a closer look.

Please note I'm not super-familiar with the runfiles implementation logic, so I have some pretty basic questions. Is build-runfiles the logic that Bazel uses to construct a target's `foo.runfiles` directory,...

Yes, these are great answers. Thank you. I'm caught up again and I'll summarize where I'm at. And my thoughts on trying to move this effectively forward: - I was...

Hi @EdSchouten . @brandjon and I discussed this yesterday. Would you be willing to output both a `runfiles_manifest` and `runfiles_manifest.json` file with the corresponding formats? That would offer format consistency:...

> Hey Greg, > > Just so I get this right: Does that mean that we should also add a foo.runfiles/MANIFEST.ndjson? Does your current patch adjust both files? Are you...

i.e. if target A depends on B and B is both private and incompatible, we'd want a build of A to report a visibility error?