Grégoire Paris

Results 254 comments of Grégoire Paris

@jkufner can you please fix the new conflicts?

> I hope it still works, it's been a long time. I'm afraid I have bad news for you :grimacing:

> I don't get how this can be considered a BC Break, while the change to make the in_array call do a strict check was not. It literally broke a...

> @greg0ire I understand that, however, the "mistake" was introducing a major change in the behavior for the IN/NOT_IN operators to use the strict checking. It was, wasn't it? >...

I found the original PR, for reference: https://github.com/doctrine/collections/pull/97

:thinking: I think this should be closed since you ended up contributing this on another branch: #249

`master` is probably no longer the right branch for this, I believe 1.8 is now.

Please associate your email address with your Github account, or change the email in your commits to an address already associated with it. If you do not want to expose...

> If we do that, people will start relying on a concrete implementation rather than an abstraction, and that would be more harmful to the ecosystem Alternatively, you can add...

> Add a new Interface as @greg0ire suggested and deprecate the old one I was Actually thinking of doing this on next minor ``` php interface NewInterface { public function...