Grégoire Paris

Results 254 comments of Grégoire Paris

@malarzm no idea yet, but it sounds better indeed, I'll try to look into that 👍

@malarzm I've taken a look at ORM, and `getValue()` seems to be called in a lot of places. I'm not quite sure the check is useful in 100% of the...

@malarzm it's already in `require-dev` :wink: This PR is a step towards sunsetting `doctrine/common`.

1. I'm trying to migrate ORM to PHP 8 syntax: https://github.com/doctrine/orm/projects/6 2. It's better to add type declarations to doctrine/common beforehand, that way I can add them as well on...

> Shouldn't ORM switch to ProxyManager first and continue PHP 8 syntax afterwards? This comment says we shouldn't: https://github.com/doctrine/orm/issues/8518#issuecomment-1124805479 > We can't really kill doctrine/common before releasing ORM 3.0 Can't...

@beberlei after #299, the extra method calls are moved to `setValue`, is that better performance-wise? This method is called less than `getValue` I suppose.

Converting to draft as determining how to replace `doctrine/common` proxy functionality might have some influence on this PR.

Thanks for reporting this. I'm the author of the BC-layer, and am already aware of the issue, but have not found a solution yet. There is some discussion about it...

Oh wow thanks that's humbling, really! Regarding the branch naming validation, when should it be performed? On creation, before push, something else? Maybe it should be configurable?

> `git checkout -b new-branch-name` Or `git branch -m` Anyway, both things can be done, and we can let the user choose on what event they want the check to...