Grégoire Paris

Results 254 comments of Grégoire Paris

To reword all this in a less troll-esque way, it's indeed right that many library do this. Beyond them, a good part do it just because other do them, and...

@tqmz: I think so too, see #2

The next blocker seems to be https://github.com/doctrine-extensions/DoctrineExtensions/issues/2708

> method isTransactionActive can return false while there is no active transaction "while" often indicates a contradiction, yet there is none in your sentence. Did you mean to write `true`...

:+1: , having a custom exception that would be thrown no matter what the exception is behind would allow to change implementations more easily. The underlying exception could still be...

Thanks! Why not make a P. R.?

Oh ok I though you were the author of that, sorry. @idciconsulting : could you make a PR ?

It seems to be working: ``` $ git diff ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── modified: Broker/Publisher.php ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── @ Broker/Publisher.php:33 @ public function __construct(FactoryInterface $factory, EventDispatcherInterface public function publish(string $messageType, Message $message, array $overridenConfig =...

> However, it is certainly a workaround and a bit hacky because it depends on the pre-collected list of console command classes where the filter should be disabled. @FlyingDR According...