Grégoire Paris

Results 254 comments of Grégoire Paris

Note that `assertCount(1, $file)` does not narrow the type either.

> This is bad, since I cannot decouple my class from Dompdf, violating the inversion of control pattern. I think you can inject it, and clone it each time before...

Yeah sorry, I realized afterwards that clones in php are shallow, you would have to implement `__clone` to do deep cloning instead (see http://stackoverflow.com/questions/2144506/what-is-object-cloning-in-php#2144675)

Yeah, it's ugly too but at least it's simple :P

Can't test right now but thanks!

I think it's a good idea. It would still result in one massive migration, right? Anyway, what I like most about this is that it would expose potential issues we...

We wouldn't do this solely for immutable types though, would we? That's what I'm referring to with "massive migration": it would impact all columns with a DC2Type comment on it,...

@derrabus @morozov , I think that would be great. Thoughts?

After reading https://github.com/doctrine/orm/issues/11313#issuecomment-1966231735, I believe it would imply changing, among other things, the signature of `QueryBuilder::orderBy()` as follows: ```diff - public function addOrderBy(string|Expr\OrderBy $sort, string|null $order = null): static +...

Sure, but people will still get the deprecation about `Criteria::ASC` and when they try to address it, :boom: