Grégoire Paris

Results 254 comments of Grégoire Paris

> They can use Order::Ascending->value instead. And then we ask them to migrate to `Order::Ascending`? That would be two migrations in a short time… not a great UX. > But...

Somewhat related: https://github.com/doctrine/orm/issues/7786

Hey @Arkemlar , the "How to reproduce" section is supposed to be filled with code allowing to reproduce the issue without any extra software (such as `doctrine/migrations` or `doctrine/orm`). Can...

Looks like the workaround with `'abs'` no longer works with recent versions of PHPStan: https://phpstan.org/r/90c4ab3a-5cbb-49a9-8220-80c78b3d63d3

Oh right! I applied that to the similar issue I'm facing, works great! Thanks!

Transferring to the DBAL since it is responsible for generating the diff. Possible next steps: reproduce this in a test case with the DBAL APIs. You can see here how...

The `Exception` part of the name can even be considered useless : - http://mnapoli.fr/approaching-coding-style-rationally/ - https://vimeo.com/album/2661665/video/74316116 But that would need creating more exception classes, because you can't really rename `DatabaseException`...

> In any way, we both agree for the Exception custom naming. Indeed, it must be changed. > It's the way used by many libraries/framework. Symfony for example follow this...

> imports list for example ``` use MyCompany\MyProject\Exception\InvalidArgumentException ``` You're right, having Exception twice makes it easier to read. But you know what would be even easier? This : ```...

PSR is different IMO: it's a discussed and validated standard, not a copied habit. They might not do it for fun, but can you find one that says why, besides...