Grégoire Paris

Great Scott!

If you need to voice your approval, please use the emoji reaction like the 12 other users that already did so. If you feel very strongly that this is needed,...

Not sure why I originally made the title so shouty, this isn't SQL

Yes, you're right, what's missing is native support for the SQL standard (as opposed to PG-specific `SERIAL` notation). It looks like there is already some support for that in `DB2Platform.php`,...

> Note, that it's a breaking change. Because it will make the diff between a database and its in-memory equivalent not empty, and will suddenly generate a lot of migrations...

> In version v2.8.0 of doctrine/dbal everithing works fine. Interesting. Can you bisect the issue down to a specific commit? If you can't consider sending a PR with your solution...

I just noticed there is `@psalm-external-mutation-free`, does this match the feature request, or is that something else?

I believe that would be appropriate for `contains()`, but using it does not seem to help: ``` ERROR: ImpureMethodCall - lib/Doctrine/Common/Collections/AbstractLazyCollection.php:70:35 - Cannot call a possibly-mutating method Doctrine\Common\Collections\Collection::contains from a...

Ok so we do indeed need something more precise than `@psalm-external-mutation-free`, where there might be an internal mutation as long as it does not affect the template item type.

@morozov are you saying `int|string` and `int|null` are not equally bad, and that you want to spot the former more easily? In yes, can you please elaborate on why they...