Add Linxura Smart Controller Zigbee mode integrate with SmartThings hub
Linxura Zigbee mode include 4 buttons, each button support press, double press, held.
Check all that apply
Type of Change
- [√] WWST Certification Request
- If this is your first time contributing code:
- [√] I have reviewed the README.md file
- [√] I have reviewed the CODE_OF_CONDUCT.md file
- [√] I have signed the CLA
- [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
- If this is your first time contributing code:
- [ ] Bug fix
- [√] New feature
- [ ] Refactor
Checklist
- [√] I have performed a self-review of my code
- [√] I have commented my code in hard-to-understand areas
- [√] I have verified my changes by testing with a device or have communicated a plan for testing
- [√] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior
Description of Change
New sub-driver for zigbee button, which support four buttons, each support press, double press, held.
Summary of Completed Tests
Does anything I need to do, before anyone can review this request?
Thank you for your suggestion, all modification has been uploaded.
@xiaodah123 @simon3panda perhaps you forgot to push to your branch? You will also need to re-base your branch to resolve the conflicts.
@xiaodah123 @simon3panda perhaps you forgot to push to your branch? You will also need to re-base your branch to resolve the conflicts.
Thank you!
We are new on this.
We‘ve re-base to Linxura_test and publish the branch.
What else we need to do?
Do I need to click 'Force push' to Current branch?
I Clicked 'Resolve conflict' button and modified file, can I click the 'Commit Merge' button?
Duplicate profile check: Passed - no duplicate profiles detected.
Channel deleted.
Test Results
65 files 421 suites 0s ⏱️ 2 141 tests 2 141 ✅ 0 💤 0 ❌ 3 668 runs 3 668 ✅ 0 💤 0 ❌
Results for commit e5ba8687.
:recycle: This comment has been updated with latest results.
| File | Coverage | |
|---|---|---|
| All files | 97% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/adurosmart/init.lua | 98% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/somfy/somfy_situo_4.lua | 98% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/shinasystems/init.lua | 97% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ecosmart/init.lua | 98% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ikea/TRADFRI_remote_control.lua | 98% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ikea/init.lua | 98% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/supported_values.lua | 99% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/init.lua | 94% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/SLED/init.lua | 95% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/button_utils.lua | 92% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/init.lua | 97% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/vimar/init.lua | 96% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/iris/init.lua | 90% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/frient/init.lua | 93% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/robb/init.lua | 99% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/wallhero/init.lua | 88% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/heiman/init.lua | 98% |
:white_check_mark: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against e5ba868709dfc4bc308161f1e3b1a8945e43c396
It would be good if you added some tests of your device's specific behavior. A good template would be this test file, which also bases its behavior off the value of the IAS Zone attribute: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-motion-sensor/src/test/test_gator_motion.lua
It would be good if you added some tests of your device's specific behavior. A good template would be this test file, which also bases its behavior off the value of the IAS Zone attribute: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-motion-sensor/src/test/test_gator_motion.lua
Tests added and uploaded. By the way is there any way for me to run the tests?
@simon3panda Yep. Assuming you've set up you dev environment following the instructions here: https://developer.smartthings.com/docs/devices/hub-connected/set-up-dev-env
Once you've done that, you can navigate in your terminal to the src directory of the specific driver and then just run lua test/[test_file_name].lua to run the tests locally.
@simon3panda Yep. Assuming you've set up you dev environment following the instructions here: https://developer.smartthings.com/docs/devices/hub-connected/set-up-dev-env
Once you've done that, you can navigate in your terminal to the
srcdirectory of the specific driver and then just runlua test/[test_file_name].luato run the tests locally.
Thank you. Tests ran. Tests result are in the attaches. aura_result.txt linxura_result.txt