Gray Gilmore

Results 70 comments of Gray Gilmore

LiquidDoc coming soon! 😄 Closing this issue with that on the horizon. Official communication for it coming soon!

v3.81.0 adds default environment support: https://github.com/Shopify/cli/releases/tag/3.81.0 Try upgrading to the latest version. I think that solves the issue that I'm seeing here but if it doesn't please let us know.

Thanks for the suggestion! We won't be considering this in the near future and will close the issue. We'd be open to reviewing a pull request if you would like...

Closing this one for now.

I have good news for you! This just recently merged: https://github.com/Shopify/theme-tools/pull/851 We're talking about adding support for JavaScript, too, but it's a slightly larger lift.

@charlespwd would you mind adding context on why this is blocked? merci!

A question to ask: is it okay to modify a generated file? We already modify template files, too. We should only be updating the `type` attribute.

@charlespwd could you add a little more context here? Maybe enough that somebody could pick this up?

Hey @david-w-shopify! I'm pretty sure the schema validation is behaving as intended here. The `"blocks"` attribute should be passed an array of objects, not a single object: https://shopify.dev/docs/storefronts/themes/architecture/blocks/theme-blocks/schema#presets

After chatting with David a bit I think there **is** a bug here. It's treating any non-valid attribute as a schema error (good!) but bubbling it up to a parent...