theme-tools icon indicating copy to clipboard operation
theme-tools copied to clipboard
verified publisher icon Shopify

Section rename handling in config/settings_data.json

Open charlespwd opened this issue 11 months ago • 1 comments

Describe the bug Looks like there's an undocumented behaviour of config/settings_data.json we'd need to think about: https://github.com/Shopify/dawn/blob/main/config/settings_data.json#L173-L185

  • Section type should be renamed
  • Does that thing accept blocks? Do we rename blocks in there too?

charlespwd avatar Jan 16 '25 16:01 charlespwd

A question to ask: is it okay to modify a generated file? We already modify template files, too.

We should only be updating the type attribute.

graygilmore avatar Aug 28 '25 16:08 graygilmore