Shopify
prettier.config.js doesn't load in extension
Describe the bug
When a user has a ESM prettier config (prettier.config.js), the formatter doesn't do anything and logs the error to the "Output > Window" logs. Nothing happens and there's no feedback to the user.
Expected behaviour We support modern prettier configs, or we gracefully handle config errors by using default configuration/error message to user.
Actual behaviour Nothing happens and the logs are in a different log window. It's confusing as hell.
@charlespwd could you add a little more context here? Maybe enough that somebody could pick this up?
IIRC There was an issue loading prettier configs from https://github.com/Shopify/theme-tools/blob/main/packages/vscode-extension/src/node/formatter.ts#L21
Vague recollection. Opening a theme with a prettier.config.js (not .json) should be enough to make Format Document in the extension do nothing at all.