graphql-js

graphql-js copied to clipboard

consider memoizing getArgumentValues

3

Maybe I don't understand something, but I didn't think it would be necessary for `GraphQLScalarType.parseLiteral` to be called every time a field argument is resolved. e.g., given this GraphQL query:...

mnpenner

SDL Validation Prior to Schema Creation

2

Recently [the issue](https://github.com/graphql-python/graphql-core/issues/122) was raised for the Python port [graphql-core](https://github.com/graphql-python/graphql-core) that enum values aren't validated against their defintion when they are used as default arguments SDL. This is the example...

Cito

Validation spec: fields implementation with default values

1

Hi! I'm the maintainer of the GraphQL for IntelliJ IDEA [plugin](https://github.com/jimkyndemeyer/js-graphql-intellij-plugin). I have a question about validating field implementations when a default value is specified. I looked through the specification...

vepanimas

add additional runtime errors for pre-coercion OneOf errors

6

This changes the implementation to match the specification. Adds additional tests as well.

yaacovCR

Consider exporting collectFields

2

My question on SO has zero answers but describes the problem the best I think: https://stackoverflow.com/questions/73650751/get-list-of-fields-to-resolve-from-a-graphql-resolver-supporting-include-direct Summary: Take this query: ``` query($userId: String!, $loadPhoto: Boolean = false) { user(id: $userId)...

henhal

remove the enhanced error messages regarding using multiple versions of graphql-js.

2

This PR removes the enhanced error messages regarding using multiple versions of graphql-js. Motivation: - Gets this library out of the package management business. - Removes our Node.JS specific code,...

yaacovCR

# Feature requests Currently we are missing changes to directive-arguments in our `findSchemaChanges` function, we'll have to cover similar cases to field-arguments.

JoviDeCroock

Publish to JSR

1

# Feature requests Deno has its own new registry named JSR, we should publish to it, however it's heavily based on provenance so an automated publishing flow is advised. This...

JoviDeCroock

instanceOf: disable dev instanceOf checks if NODE_ENV not set

4

development behavior should be opt in, not opt out https://github.com/graphql/graphql-js/issues/4075#issuecomment-2088870697

yaacovCR

Memoization of collectSubfields issue (optimization potential)

2

The memoization of the `collectSubfields` function in `execute.js` has a subtle issue that makes the caching less effective than it could be. The problem is that the `WeakMap` in `memoize3`...

Cito