graphql-js
graphql-js copied to clipboard
graphql
instanceOf: disable dev instanceOf checks if NODE_ENV not set
development behavior should be opt in, not opt out
https://github.com/graphql/graphql-js/issues/4075#issuecomment-2088870697
Deploy Preview for compassionate-pike-271cb3 ready!
| Name | Link |
|---|---|
| Latest commit | 079409e9f3e2781178e77e6093855bc2dea50464 |
| Latest deploy log | https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66e006b02d79130008425d38 |
| Deploy Preview | https://deploy-preview-4188--compassionate-pike-271cb3.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋
Supported commands
Please post this commands in separate comments and only one per comment:
@github-actions run-benchmark- Run benchmark comparing base and merge commits for this PR@github-actions publish-pr-on-npm- Build package from this PR and publish it on NPM
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This will still not fix #4017. An alternative to this PR would be to rearchitect the instanceOf checks more completely....
@JoviDeCroock @phryneas @benjie
@yaacovCR yes as proposed in https://github.com/graphql/graphql-js-wg/issues/125
