graphql-js
graphql-js copied to clipboard
remove the enhanced error messages regarding using multiple versions of graphql-js.
This PR removes the enhanced error messages regarding using multiple versions of graphql-js.
Motivation:
- Gets this library out of the package management business.
- Removes our Node.JS specific code, tracked in #2317
- Removes need for complicated build instructions for package managers (helpfully added in #4022)
- Removes browser incompatibility bug, #4017 (in quite a blunt way).
- Obviates the need for #4188 to switch default to production.
Downside:
- Removes helpful error messages in tricky-to-debug cases where build tools/frameworks/consumers may end up inadvertently using multiple versions of graphql. While the fixes for this error have gotten easier now that additional package management tools have adopted the ability to set resolutions/overrides, and awareness around this issue has perhaps increased, this change will cause more opaque error messages in that hopefully dwindling number of cases.
This PR should be thought of a strawman PR for discussion.
If we do want to re-enter the package management business to some extent, we could combine this with #3915 => although that PR would only protect us going forward with versions that will support Symbol.for().
Deploy Preview for compassionate-pike-271cb3 ready!
| Name | Link |
|---|---|
| Latest commit | 3a3b7e873d946b474487566221503db0b1e8c07b |
| Latest deploy log | https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/670e1e3bea8fb60008899825 |
| Deploy Preview | https://deploy-preview-4238--compassionate-pike-271cb3.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋
Supported commands
Please post this commands in separate comments and only one per comment:
@github-actions run-benchmark- Run benchmark comparing base and merge commits for this PR@github-actions publish-pr-on-npm- Build package from this PR and publish it on NPM