Grant McLean

Results 17 comments of Grant McLean

In my app, setting a height of `1fr` achieve the desired effect - YMMV.

> @grantm You have a failing snapshot test that needs updating before this can be merged I've just pushed a commit to fix that snapshot test. The next issue will...

Is there anything further I need to do on this one? I seem to recall there was quite a spate of flakey tests blocking it. I now have a set...

I haven't forgotten about this, but it's a "work thing" and I've had other work priorities. Since so much has changed with the tests since I originally did this, I...

I'm not sure it's a weird as you think (minor nitpick, it's not actually hosted on Read the Docs it's just built using the same toolchain). There's plenty of precedent...

So your proposal is to simply propagate the tabindex value from the original input if it has one to all three input elements in the generated widget? That sounds like...

Thanks for this! I hope to get a chance to review this in a week or so.

I can see how that could happen and it's not a use case I have experience with. Happy to consider a pull request.

Thanks for your feedback. I intend to record a new intro video to cover the features added since I did the original. I'll definitely bear your feedback in mind.