matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Make the "Voice message" button in the message composer configurable

Open grantm opened this issue 2 years ago • 6 comments

  • With this change the user can choose to hide the "Voice message" button in the message composer menu.

  • The site administrator may also choose to hide the button by including this in the site config:

    "setting_defaults": { ... "MessageComposerInput.showVoiceRecordingButton": false, ... },

  • Note: the button label reads "Voice Message" but the code refers to it as the voiceRecordingButton.

Checklist

  • [X] Tests written for new code (and old code if feasible)
  • [X] Linter and other CI checks pass
  • [X] Sign-off given on the changes (see CONTRIBUTING.md)

Type: enhancement


Here's what your changelog entry will look like:

✨ Features

  • Make the "Voice message" button in the message composer configurable (#11603). Contributed by @grantm.

grantm avatar Sep 13 '23 02:09 grantm

@grantm You have a failing snapshot test that needs updating before this can be merged

robintown avatar Sep 19 '23 03:09 robintown

@grantm You have a failing snapshot test that needs updating before this can be merged

I've just pushed a commit to fix that snapshot test.

The next issue will likely be a merge failure due to other changes in src/i18n/strings/en_EN.json. What's the preferred way to deal with rebasing a patch? Can I rebase, resolve and force push to my PR?

grantm avatar Sep 19 '23 10:09 grantm

force pushing will discard review so please avoid it. We squash merge so don't worry about it.

t3chguy avatar Sep 19 '23 10:09 t3chguy

Is there anything further I need to do on this one?

I seem to recall there was quite a spate of flakey tests blocking it. I now have a set up where I can run the Cypress tests and I see the following three test failing consistently as of today:

  • crypto/crypto.spec.ts
  • presence/presence.spec.ts
  • read-receipts/redactions.spec.ts

The failures don't seem to be related my change and the same tests fail in the same way on develop without my changes.

grantm avatar Nov 15 '23 23:11 grantm

It looks like the code coverage for the change is not sufficient for it to pass the gate

t3chguy avatar Nov 15 '23 23:11 t3chguy

OK, thanks. I'll take a look.

grantm avatar Nov 15 '23 23:11 grantm

@grantm hey any update on this?

t3chguy avatar Jul 29 '24 09:07 t3chguy

I haven't forgotten about this, but it's a "work thing" and I've had other work priorities. Since so much has changed with the tests since I originally did this, I wondered if starting fresh might be easiest.

grantm avatar Jul 29 '24 22:07 grantm