grandizzy
grandizzy
@avorylli oh, yes, I tested and def the right direction, there's still a little flakiness to figure it out, will get on review it asap
@Haxry pls don't introduce ethers dep bit use alloy. Also pls add a test for the new cheatcodes and make sure priv key is redacted in traces, you can add...
> @grandizzy plz review ! are the changes ok ? I'll add the test too ! yep, lgtm! I run `cargo cheats` and pushed commit to fix CI, would be...
> Hey Thanks for implementing this feature. I'll test it on my project today Awesome, thanks. Mind that the PR wasn't merged yet so you'll need to build locally and...
> @Haxry I hope this example can help: > > https://github.com/aviggiano/foundry-vm-signtypeddata/blob/db023ea33bfa4979a59a5fa00bfd85204a56e987/script/SignTypedData.s.sol#L23-L46 > Confirm this works with the current cheatcode which requires a private key, one difference though is that the...
going to close this one in favor of fix of https://github.com/foundry-rs/foundry/issues/10986
> @grandizzy good to merge? Yep, let's send it 👍
it seems like the CI failure for Win is a legit one, need to investigate it why happens
> > it seems like the CI failure for Win is a legit one, need to investigate it why happens > > I tried to rebase but CI is now...
I see win failing with same overflow I get locally re WalletOpts, checking why this happens 👀