grandizzy

Results 349 comments of grandizzy

I was not able to reproduce this one anymore since https://github.com/foundry-rs/foundry/pull/7552 fix, @apbendi would you mind retest? thanks

failure can be also reproduced by placing a `failures` file in `cache/fuzz/` dir with following content ``` # Seeds for failure cases proptest has generated in the past. It is...

> I tried to figure out how to add a test as instructed [here](https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md), but I didn't figure it out. appreciate if anyone could kindly point out how to add...

> Hi @mattsse @grandizzy , I'm wondering if my updated PR meets the requirements for testing. If not, I'd like to discuss further and make improvements. hope to see this...

the way #2551 is implemented is that when a fuzz failure occurs it is persisted and always replayed first on subsequent runs, so the test will exit right away. If...

a simpler fix would be to assume it's a test function only if they don't have outputs by adding `&& self.outputs.is_empty()` condition here https://github.com/foundry-rs/foundry/blob/e01038f35750b4a41b1eda5a4ea3da976027eee2/crates/common/src/traits.rs#L51-L57 This is a breaking change for...

Thank you, makes sense, maybe this one could just be retired then

I *think* this could be workarounded by using a `MAINNET_ETHERSCAN_API_KEY` in env and in `foundry.toml` ``` mainnet = { key = "${MAINNET_ETHERSCAN_API_KEY}" } ```

that's by intent the L1 block see https://github.com/foundry-rs/foundry/blob/master/crates/evm/core/src/utils.rs#L70C1-L75C41 ```rust // on arbitrum `block.number` is the L1 block which is included in the // `l1BlockNumber` field ```

> > that's by intent the L1 block see https://github.com/foundry-rs/foundry/blob/master/crates/evm/core/src/utils.rs#L70C1-L75C41 > > ```rust > > // on arbitrum `block.number` is the L1 block which is included in the > >...