grandizzy

Results 349 comments of grandizzy

> 2. Suppress the warning by adding #[allow(clippy::too_many_arguments)] to this function. this should be fine IMO

@cassc could you please check https://github.com/foundry-rs/foundry/issues/2846#issuecomment-1260103355 would like to know if we could tackle all points in the PR (or as a follow-up). Thank you!

also wonder if we need the new `--with-state-changes` arg or we could just use verbosity for displaying such, @zerosnacks wdyt? thanks

> > @cassc could you please check [#2846 (comment)](https://github.com/foundry-rs/foundry/issues/2846#issuecomment-1260103355) would like to know if we could tackle all points in the PR (or as a follow-up). Thank you! > >...

this should be good to go but probably worth one more reviewer since @zerosnacks and I were also adding code to it

@mds1 I think it makes sense to have such directly in foundry and have strategies generate values in bounded range. What I can see here as a potential issue is...

> How would you specify distribution type with fixtures? Yeah, wasn't thinking to use fixtures for distribution but maybe having a similar way to current fixtures for all configuration of...

@anajuliabit would it be possible to provide more informations on the failure (which RPC, fork block heights, etc), we're looking into a constant reproducing the issue to understand where the...

> The 520s seem to be intermittent and not correlated with any single network or RPC provider. Perhaps you could implement an exponential backoff/retry for these instead of crashing? Hey...

possible ref to https://github.com/foundry-rs/foundry/issues/4522